Weekly Dev Update #35

Summary

The team spent the week validating THORChain’s ability to start, churn up to 12 nodes, then back down to 4 nodes, initiate a Ragnarök and complete a shutdown. The team were able to achieve a full-life cycle at the end of the week, and many small bugfixes were made along the way.

In addition, the team completed the last of Certik’s Audit report fixes, as well as implementing Blame into THORChain.

Testing continues on BEPSwap, with the bulk of the work in adding BigNumbers.js to BEPSwap which required a full re-write of core arithmetic functions.

Testing and QA flows on to tweaks and additions to Midgard API — which is difficult to test until connected to BEPSwap, since a lot of what Midgard outputs is user consumable.

THORNode

• certik report fix 3
• Resolve “[FIX] certik report minor issues”
• Resolve “Invalid Fee value for failed swap event”
• Resolve “Invalid fee for double swap”
• Add some comments for getMsgStakeFromMemo cover multi-chain
• [bugfix] correct ygg funding amounts
• Resolve “ADD: Event for slash a node account”
• [bugfix] check vault balances before selecting
• [bugfix] fund yggdrasil after validator rotation
• [bugfix] check node account bond when marking nodes as “ready”
• [bugfix] get all yggdrasil vaults with funds
• [bugfix] dont check coins when handling yggdrasil return outhash
• [bugfix] track blockheight with binance metadata and broadcast bugfix
• [bugfix] tiny misc bug fixes
• Add cmd to refund testnet
• [bugfix] patch incorrect vault coins length

THORChain TSS

• 79-issue when the signature data is nil , return fail to avoid panic
• Resolve “Keep signature notification timeout and join party timeout consistent…”
• Resolve “correct the blame reason in coordiantion phase”
• add MaxPayload check
• 83-issue update signature notify implementation to verify signature instead of…
• 86-issue fix a data race issue
• 77-issue move p2p_message to messages folder

Midgard API

• Resolve “Invalid assetdepth after reward event”
• Resolve “Invalid rune/asset depth after swap event”
• Resolve “Serialize big numbers as string”
• Resolve “Serialize `double` / `float` of any amounts or price into `string`”
• Resolve “asset/rune stake overflow after unstake event”
• Resolve “Invalid PoolROI12”
• Resolve “Revert values for dates back to numbers”
• Resolve “ISSUE: poolVolume24hr returning incorrect data”
• Resolve “Panic on failed swap event”
• Resolve “ADD slash event handler”
• Resolve “Pagination for `tx/{address}` endpoint”
• Resolve “`v1/tx/` endpoint responses with same timestamp for all transactions”

BEPSwap Client

• Use `reserved-words-mappings` option
• Fix: Pool shares are missing
• Fix route handling in header (incl. migration of `header` into TypeScript)
• Resolve “Midgard API reverted values for dates back to numbers”
• Resolve “Update latest Midgard API changes: Serialization of `double` / `float` into `string”
• Resolve “Handle dates from Midgard as an UNIX timestamp in seconds (not in milliseconds)”
• Resolve “Connect wallet: Re-direct to prevoius page”
• Resolve “Transaction page: Please connect your wallet”
• Extract UI for “add wallet”
• Resolve “Navigation broken on `/` route”
• Introduce big numbers
• Resolve “Transaction history table: Warning about missing unique `rowKey` in table”
• Resolve: “BUG: Invalid memo while swapping RUNE -> BNB” and “BUG: Memo includes wrong value for target pool”
• Fix validation while staking and hide tx modals on error
• Resolve: “Bug: Formats of fee + slip valures on tx history page are incorrect”
• Resolve: BUG: Withdraw stake numbers are in base number format.
• Resolve: “Tx history table: Show time of transaction”
• Improve error handling for adding a keyfile
• Introduce `maxSec` to stop tx counter
• Resolve “ADD: Asset price (pool price) to pool list.”

Asgard Wallet

• Add send funds in react. Related to #32, #101
• Feature/migrate mnemonic confirm
• Add AntD, and use unlock component. Related to #133, #135, #137
• Feature/migrate start antD

Bounty Program

There are currently open bounties on Asgard Wallet codebase:

Issues · THORChain / Asgard WalletAsgard WalletAsgard Walletgitlab.com

In addition, the team are working with a number of community developers on some specific tasks.

Audit

Code Review: Complete

Economic Review: Completed most of THORChain's economic architecture

TSS Audit: expected to begin soon

Next Milestones

The updated testnet is in the final stages of testing. Chaosnet is expected once testnet has been fully-validated in several environments. There currently isn’t any known blockers to Chaosnet release.

Community

To keep up to date, please monitor community channels, particularly Telegram and Twitter:

• Twitter: https://twitter.com/thorchain_org
• Telegram Community: https://t.me/thorchain_org
• Telegram Announcements: https://t.me/thorchain
• Reddit: https://reddit.com/r/thorchain
• Github: https://github.com/thorchain
• Medium: https://medium.com/thorchain