Weekly Dev Update #36

Summary

Happy Path Testing was completed on THORChain and the network was validated to perform as expected:

• Start with genesis nodes, churn up to 12 bonded nodes.
• Complete swaps and staking transactions concurrently.
• Migrate funds from vault to vault.
• Churn down to 4 nodes, start Ragnarok.
• Finish Ragnarok with all funds returned.

The team began Unhappy Path Testing which ensures the network can tolerate malicous or offline nodes in the same environment above. As always, the tweaks and bugfixes that corrected issues identified above were merged below.

THORNode

Bugfixes

• [bugfix] track blockheight with binance metadata and broadcast bugfix
• [bugfix] tiny misc bug fixes
• [bugfix] patch incorrect vault coins length
• [bugfix] last bnb unstake exclude portion of bnb for gas
• [bugfix] increment seqnum only after successful broadcast
• [bugfix] slash ygg, migrate, and ragnarok memo when appropriate
• [bugfix] don’t return a point for keysign func
• [bugfix] update frontend docker image url
• [bugfix] add json attr
• [bugfix] slash ygg for using an inbound memo as an outbound memo
• [bugfix] observe addrs after txn is processed

Additional Work

• Add cmd to refund testnet
• Update makefiles and conf to avoid conflicts
• Resolve “[ADD] expose a new endpoint for constant values”
• [bugfix] slash yggdrasil when funds are stolen with a bad memo
• Resolve “[ADD] Update HasMajority for tss blame”
• [refactor] require exact match for outbound transactions
• Resolve “Don’t sign old transactions”
• 377-issue update gas
• Probabilistic churn in selection
• [revert] revert probabilistic churn in
• Resolve “[ADD] Versionize slashing”
• [refactor] reduce logging
• 385-issue remove keygen client
• Add unit test for bifrost hash

THORChain TSS

Work continues to improve reliability.

• 83-issue update signature notify implementation to verify signature instead of…
• 86-issue fix a data race issue
• 77-issue move p2p_message to messages folder
• fix the docker compose
• Resolve “[FIX] join party timeout consistently.”

Midgard

Bug fixes from issues identified in E2E testing.

• Resolve “Pagination for `tx/{address}` endpoint”
• Resolve “`v1/tx/` endpoint responses with same timestamp for all transactions”
• Resolve “Update runeEarned and assetEarned formula”
• Resolve “Invalid assetROI and runeROI”
• Resolve “Wrong poolTxAverage calculation”
• Resolve “Wrong poolSlipAverage calculation”
• Resolve “Wrong sellFee and buyFee calculation”
• Resolve “Return total number of transactions (or pages) at `/v1/events`”

BEPSwap

Transaction page completion as well as bug fixes from E2E testing.

• Resolve “Transaction history table: Warning about missing unique `rowKey` in table”
• Resolve: “BUG: Invalid memo while swapping RUNE -> BNB” and “BUG: Memo includes wrong value for target pool”
• Fix validation while staking and hide tx modals on error
• Resolve: “Bug: Formats of fee + slip valures on tx history page are incorrect”
• Resolve: BUG: Withdraw stake numbers are in base number format.
• Resolve: “Tx history table: Show time of transaction”
• Improve error handling for adding a keyfile
• Introduce `maxSec` to stop tx counter
• Resolve “ADD: Asset price (pool price) to pool list.”
• Access `v1/events` endpoint
• Resolves: “Tx history: Sort table data by date”
• Resolve: “Transaction page: Improve ui for errors”
• Resolve “ADD: Transaction Page”
• Resolve: “BUG: Pool share incorrect.”
• Extract common Binance Chain sources to `asgardex-common`
• Use `async` helper from `asgardex-common`
• Use `bn` helpers of `asgardex-common`
• ensure master ci builds deploys to cloudfront

Asgard Wallet

Migration to Ant Design Framework.

• Feature/migrate start antD
• Fix Wrong Images (#145)
• Resolve: Add: Number View Format (#146)
• Feature/antd migration fonts enhancements
• FIX: (#154) keystore export name
• Feature/migrate unlock options ant d
• Update ReadMe (#160)
• ADD: useTracker()
• Switch view styling to AntD. Related to #158

Bounty Program

There are currently open bounties on Asgard Wallet codebase:

Issues · THORChain / Asgard WalletAsgard WalletAsgard Walletgitlab.com

In addition, the team are working with a number of community developers on some specific tasks.

Audit

Code Review: Complete

Economic Review: Completed most of THORChain's economic architecture

TSS Audit: expected to begin soon

Next Milestones

The updated testnet is in the final stages of testing. Chaosnet is expected once testnet has been fully-validated in several environments. There currently isn’t any known blockers to Chaosnet release.

Community

To keep up to date, please monitor community channels, particularly Telegram and Twitter:

• Twitter: https://twitter.com/thorchain_org
• Telegram Community: https://t.me/thorchain_org
• Telegram Announcements: https://t.me/thorchain
• Reddit: https://reddit.com/r/thorchain
• Github: https://github.com/thorchain
• Medium: https://medium.com/thorchain